Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fix how indices are computed, add attrib indices #929

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

fb55
Copy link
Owner

@fb55 fb55 commented Aug 27, 2021

The previous approach had several short-comings; eg. special comments like </12> or CDATA in HTML would have misreported indices.

As a new feature, attributes will now have indices set appropriately.

The previous approach had several short-comings; eg. _special_ comments like `</12>` or CDATA in HTML would have misreported indices.

As a new feature, attributes will now have indices set appropriately.
@fb55 fb55 enabled auto-merge (squash) August 27, 2021 16:56
@fb55 fb55 merged commit 28c162b into master Aug 27, 2021
@fb55 fb55 deleted the refactor/indices branch August 27, 2021 16:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1175005794

  • 28 of 29 (96.55%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 98.488%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/fixtures/test-helper.ts 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
src/Parser.ts 1 98.83%
Totals Coverage Status
Change from base Build 1174398383: -0.2%
Covered Lines: 912
Relevant Lines: 926

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants