Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forwarding attachments #420

Merged
merged 7 commits into from
Apr 25, 2019

Conversation

kapi2289
Copy link
Contributor

client.forwardAttachment("[REDACTED ATTACHMENT ID]", "[REDACTED THREAD ID]")

Copy link
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT so far 👍. Are you ready to merge this, or do you want to add an attribute on Message that says whether or not it's a forwarded message? (This can be done by checking if "source:chat:forward" is in the tags list)

fbchat/utils.py Outdated Show resolved Hide resolved
@madsmtm madsmtm merged commit 70faa86 into fbchat-dev:master Apr 25, 2019
@kapi2289 kapi2289 deleted the forwarding-attachments branch April 25, 2019 20:07
madsmtm added a commit that referenced this pull request Jun 23, 2019
- Removed / privatized a lot of undocumented functionality, which might break some users application if they were relying on those (hence the minor version bump). See #432 for further reasoning
- Add `Client.forwardAttachment` and `Message.forwarded` attribute, see #420
- Fix parsing subattachments with no target, see #412
- Lots of other refactoring, aka. work on the transition towards v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants