Add US state button to bottom of agency search results #1028
Conversation
jeremiak
added
workflow: in-progress
workflow: review
and removed
workflow: in-progress
labels
jeremiak
force-pushed
the
jk-agency-search-info
branch
from
bfb08f4 to
1227aae
Compare
|
my understanding was that this section would be pinned / always at the bottom of the agency search results box (so you didn't have to scroll to see) if that's true, do u want to merge this and then have a new PR with that tweak? |
|
@brendansudol asking @amberwreed to confirm the plan here. |
|
@brendansudol: yep, the button should be pinned/always at the bottom so you dont have to scroll to see it. |
|
@brendansudol I think we should merge this and then try that out in a different PR. I'm concerned that its going to result in a very small amount of scrolling space for a list that is potentially very long. On the other hand, perhaps it doesn't matter since it has filtering behavior based on what the user enters as an agency name/ORI/etc. |
|
yep, agreed and we may have to make height of that dropdown a little bigger to accommodate |
| @@ -37,6 +46,8 @@ const AgencySearchResults = ({ data, groupKey, groupValues, onClick }) => { | |||
| data: noFederal.filter(d => d[groupKey] === null), | |||
| }) | |||
|
|
|||
| const usState = oriToState(noFederal[0].ori) | |||
There was a problem hiding this comment.
i think we should pass usState down as a prop rather than parse and lookup from ORIs (since it's available in the LocationFilter component)
|
🚢 |
Refs #1009