Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade webpack + related packages #1147

Merged
merged 2 commits into from
Jul 10, 2017
Merged

Conversation

brendansudol
Copy link
Contributor

this will help facilitate future hot reload work

@brendansudol
Copy link
Contributor Author

finally using webpack 2 :)

@jeremiak
Copy link
Contributor

Nice! I combined the webpack configs into a single one so that the process of rebuilding is a bit faster. The problem with this current implementation is that nodemon build/server.js expects a file to be there before it is so the command generates an error pretty quickly. However, once the bundle is generated, the app works fine.

We don't need to have two different webpack processes playing off of
each other when we can supply two different configs for the same process
@jeremiak jeremiak force-pushed the bjs-build-package-upgrades branch from a3bfb59 to efa6d89 Compare July 10, 2017 21:46
@jeremiak jeremiak merged commit 0f40743 into master Jul 10, 2017
@jeremiak jeremiak deleted the bjs-build-package-upgrades branch July 10, 2017 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants