Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add percent/count toggle to stack bar chart, other small design changes #1182

Merged
merged 2 commits into from
Aug 2, 2017

Conversation

jeremiak
Copy link
Contributor

@brendansudol
Copy link
Contributor

can you post screenshots of how this now looks here (as well as how this looks on mid/small screens when this nibrs card is stretched)?

@jeremiak
Copy link
Contributor Author

Here is how this looks across a few different display sizes:
responsive-stacked-percent-toggle

The most problematic to me is this stretched breakpoint, but not sure if this is problematic. I do think this might look better with the bar chart centered as it was. Perhaps we center the chart but keep the rest of this in place?
screen shot 2017-07-28 at 1 23 02 pm

@brendansudol
Copy link
Contributor

brendansudol commented Jul 28, 2017

i agree with you @jeremiak that this looks better when centered (with the bottom axis to keep it from just floating and making it consistent with the histogram chart below)

When left-aligned, I feel like there's too much white space in the middle; having content on the edges but not the middle seems less than ideal.

I would be in favor of keeping it as is (vs. how it looks in images above) -- curious for @AvivaOskow and @LarryBafundo to offer their thoughts here

@jeremiak jeremiak force-pushed the jk-small-nibrs-design branch from 48afde1 to 946a4ed Compare August 1, 2017 23:49
@jeremiak
Copy link
Contributor Author

jeremiak commented Aug 1, 2017

Thanks for the feedback @brendansudol. I'm going to remove 946a4ed but merge the rest

@jeremiak jeremiak force-pushed the jk-small-nibrs-design branch from 946a4ed to 073e9e8 Compare August 1, 2017 23:58
@jeremiak jeremiak merged commit 083bd93 into master Aug 2, 2017
@jeremiak jeremiak deleted the jk-small-nibrs-design branch August 2, 2017 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants