Bind action creators to dispatch for page level components and remove appState #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiak
added
workflow: in-progress
workflow: review
and removed
workflow: in-progress
labels
added 2 commits
August 15, 2017 00:06
Removing the dispatch prop in favor of an object called actions that is the necessary action creators bound with the dispatch function by the time they are passed into the component. Also reduce the appState prop that is passed in, particularly to <Explorer /> so that page level components can use connect() to get the parts of app state that they care about and it isn't passed in from higher props.
Passing around appState is sort of annoying because it isn't that descriptive and it really only came from <App />. Now that we have a separate page level component directory, most of them are connected to the store and therefore can pull the relevant parts from appState for themselves.
jeremiak
force-pushed
the
jk-bind-action-creators
branch
from
c27ac84 to
319f400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the pattern from
<App />to bind action creators to dispatch (so that we don't need to pass dispatch into the props of a component) in the page level components (/src/pages) for consistency.Also remove
appStateso that the page level components can useconnect()to pull the relevant parts of the application state for themselves.