Refactor mungeSummaryData util function #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiak
added
workflow: in-progress
workflow: review
and removed
workflow: in-progress
labels
The mungeSummary data function was doing quite a bit all in one call which made it require a lot of parameters and was harder to follow. It has been refactored into a series of smaller helper functions that are used at different points in the app. This way the data is reduced into a more usable form that requires no further calculation, just shape manipulation and filtering. Added tests for all new functions in summary util
jeremiak
force-pushed
the
jk-summary-util
branch
from
ea79145 to
8d6682e
Compare
jpwentz
approved these changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR isn't not against master, but
jk-jw-all-composite-chartswhich is another in-progress feature branch.The
mungeSummarydata function was doing quite a bit all in one call which made it require a lot of parameters and was harder to follow. It has been refactored into a series of smaller helper functions that are used at different points in the app. This way the data is reduced into a more usable form that requires no further calculation, just shape manipulation and filtering.Added tests for all new functions in summary util