-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
508 Fixes #1210
508 Fixes #1210
Conversation
fe00953
to
448404b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove rounded corners for everything and have everything have sharp angles for consistency
If we like the outline, we should also put it on the homepage:
I'm not sure I like the outline now that I see it all together since it really highlights the select menus, but maybe that's a good thing. I could go either way as long as it is consistent across the app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
I'm fine with these changes though I'm not a fan of them aesthetically since I like the cleaner look. I'm not sure the borders are necessary for 508 compliance since the text and its background still have a high contrast and they are tab-able/respond normally to keyboard input.
One weird thing I noticed is that if we do go down this route, the hover on the crime type filter does not have rounded corners which isn't consistent. However, if the hover state and selected state both have rounded corners (or either, I suppose) then they won't match up exactly if the are consecutive in the UI (stacked on top of each other).
@jpwentz up to your design discretion, feel free to merge
…-data-frontend into jw-fiou-508-compliance
…-data-frontend into jw-fiou-508-compliance
…-data-frontend into jw-fiou-508-compliance
Ended up being fixed in a different branch. Will keep this in the changelog for reference. |
Minor Changes to add Borders to certain buttons and selects.