Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

508 Fixes #1210

Closed
wants to merge 18 commits into from
Closed

508 Fixes #1210

wants to merge 18 commits into from

Conversation

jpwentz
Copy link
Contributor

@jpwentz jpwentz commented Aug 22, 2017

Minor Changes to add Borders to certain buttons and selects.

@jeremiak jeremiak force-pushed the jw-fiou-508-compliance branch from fe00953 to 448404b Compare August 22, 2017 22:42
Copy link
Contributor

@jeremiak jeremiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove rounded corners for everything and have everything have sharp angles for consistency
screen shot 2017-08-22 at 3 46 15 pm

If we like the outline, we should also put it on the homepage:
screen shot 2017-08-22 at 3 46 27 pm

I'm not sure I like the outline now that I see it all together since it really highlights the select menus, but maybe that's a good thing. I could go either way as long as it is consistent across the app.

@jpwentz
Copy link
Contributor Author

jpwentz commented Aug 23, 2017

  • Currently there are more inputs with rounded edges than sharp edges. Therefore I converted the only other sharp edge input to rounded edge (Crime Type Filter) for consistency.
  • Attached shows that the borders are applied to the the Home screen
    cde_screenshot_508

Copy link
Contributor

@jeremiak jeremiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

I'm fine with these changes though I'm not a fan of them aesthetically since I like the cleaner look. I'm not sure the borders are necessary for 508 compliance since the text and its background still have a high contrast and they are tab-able/respond normally to keyboard input.

One weird thing I noticed is that if we do go down this route, the hover on the crime type filter does not have rounded corners which isn't consistent. However, if the hover state and selected state both have rounded corners (or either, I suppose) then they won't match up exactly if the are consecutive in the UI (stacked on top of each other).

@jpwentz up to your design discretion, feel free to merge

@jeremiak
Copy link
Contributor

Ended up being fixed in a different branch. Will keep this in the changelog for reference.

@jeremiak jeremiak deleted the jw-fiou-508-compliance branch August 30, 2017 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants