Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Logic to Map Actual Values to Reported Term #1264

Merged
merged 8 commits into from
Oct 12, 2017

Conversation

jpwentz
Copy link
Contributor

@jpwentz jpwentz commented Oct 4, 2017

No description provided.

@jeremiak
Copy link
Contributor

jeremiak commented Oct 4, 2017

Sorry about ^^, I pressed the wrong button by accident.

FWIW, I find this to be pretty confusing for more sophisticated data consumers as “reported” has a strict definition and is in the glosdary. I think that a definition for “actual” be added (https://github.com/18F/crime-data-frontend/issues/1260) and that a third word is used that does not have a definitional collision with important UCR terms.

@jpwentz
Copy link
Contributor Author

jpwentz commented Oct 4, 2017

@jeremiak I totally agree -- but we were provided with justification from the Product Owners -- they also want it updated in the CDE database as well; which I'm can resistance to do since we only have a production database.

@jpwentz jpwentz changed the title Adds Logic to Map Actual Values to Recorded Term Adds Logic to Map Actual Values to Reported Term Oct 4, 2017
@jeremiak
Copy link
Contributor

jeremiak commented Oct 4, 2017

On our last call last week I remember Cindy agreeing to just add the definition for the "actual" term as anything else is likely to be really confusing and conflict with other parts of the site. Isn't she the product owner?

@jpwentz
Copy link
Contributor Author

jpwentz commented Oct 4, 2017

Yes she is. She wants Actual to be renamed Reported -- and Reported to be renamed Initial.

-Jacob

@jpwentz jpwentz merged commit 8df3def into master Oct 12, 2017
@jeremiak jeremiak deleted the jw-reported-actual-term-change branch December 5, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants