Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add util tests #480

Merged
merged 16 commits into from
Mar 3, 2017
Merged

Add util tests #480

merged 16 commits into from
Mar 3, 2017

Conversation

jeremiak
Copy link
Contributor

@jeremiak jeremiak commented Mar 2, 2017

Refs #465

@jeremiak jeremiak force-pushed the jk-util-tests branch 2 times, most recently from 29b72a5 to 5dc010d Compare March 2, 2017 04:59
@jeremiak
Copy link
Contributor Author

jeremiak commented Mar 2, 2017

As of a316f97, coverage for /src/util has gone up a lot:

commit % Stmts % Branch % Funcs % Lines
0982245 68.9 61.54 64.29 71.74
a316f97 92.68 92.31 89.29 93.53

Remaining tests to be written are for the /util/nibrs utility

@brendansudol
Copy link
Contributor

so, so awesome 💥

Jeremia Kimelman added 3 commits March 2, 2017 12:59
Since we always expect some props to be passed to
UcrParticipationInformation they should be required for easier error
catching
@jeremiak jeremiak changed the title [WIP] Add util tests Add util tests Mar 3, 2017
@jeremiak
Copy link
Contributor Author

jeremiak commented Mar 3, 2017

Coverage report as of 75d46ae for the /src/util directory:

directory % Stmts % Branch % Funcs % Lines
util 99.42 93.02 100 100

Ready for review @brendansudol

@brendansudol brendansudol merged commit e84449a into master Mar 3, 2017
@brendansudol brendansudol deleted the jk-util-tests branch March 3, 2017 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants