handle missing data in trend chart #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@brendansudol This looks great. I think the last remaining bit to implement before we can merge is the indicator that tells the user what the darker gray bands mean (see design here) |
|
ah, great call -- will add that a bit later today and will be ready for your 👀 first thing tomorrow |
brendansudol
force-pushed
the
bjs-handle-missing-trend-data-ranges
branch
from
1f2a79d to
cc1393b
Compare
brendansudol
force-pushed
the
bjs-handle-missing-trend-data-ranges
branch
from
cc1393b to
4f1121d
Compare
|
i believe this is ready now preview: |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.