import grouping/ordering consistency #602
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jeremiak -- i want to propose a pattern/standard for our file imports:
module
name (as opposed to thefunction(s)
names. i think this has a few benefits: 1) it keeps related things together (for example,d3-array
,d3-scale
, etc., regardless of what the specific functions we import from those libraries are) 2) it means that if we change the name of a function that we import (or if we update which functions we import), we don't have to move the line that it's on.../foo
, then../foo2
, then../../bar
...)let me know what you think! if you like this, i'll update the remaining files :)