Fetch national participation data #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we fetch the national participation data from the API, we cannot assume it will just be there when we need to draw trend lines. Because shouldFetchUcr will return true for the nationalKey when it is the place and we don't want to fire off two requests for the same data, fetchNational will be false when the place is national.
|
good catch, thx for handling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we fetch the national participation data from the API, we cannot assume it will just be there when we need to draw trend lines. Right now this is causing the explorer interface to crash.
Because
shouldFetchUcr()will return true for thenationalKeywhen it is the place and we don't want to fire off two requests for the same data,fetchNationalwill be false when the place is national.