Zip CSV file downloads so there is only one file #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 5, 2017 19:07
The browser alert/permission request to download multiple files is subtle on many popular browsers so it was confusing people as to why their files didn't download. Instead, we can wrap all the files into a single .zip file so that the user can easily get all the relevant data.
brendansudol
reviewed
Apr 6, 2017
src/components/DownloadDataBtn.js
Outdated
|
|
||
| if (!multipleFiles && first.url) return triggerUrlDownload(first.url) | ||
|
|
||
| zip.file(`${dirname}/README.md`, `#${lowerCase(dirname)}\n`) |
There was a problem hiding this comment.
does there need to be a space after the # in the second parameter?
|
modulo the codeclimate nit, looks good, and nice usability lift |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The browser alert/permission request to download multiple files is subtle on many popular browsers so it was confusing people as to why their files didn't download. Instead, we can wrap all the files into a single .zip file so that the user can easily get all the relevant data.