-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First pass at agency search functionality #765
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendansudol
force-pushed
the
bjs-start-ori-search
branch
2 times, most recently
from
May 19, 2017 17:32
45a6af6
to
279df58
Compare
jeremiak
changed the title
[WIP] agency search functionality
First pass at agency search functionality
May 22, 2017
@brendansudol I believe this is ready for review now |
Merged
jeremiak
force-pushed
the
bjs-start-ori-search
branch
from
May 23, 2017 14:58
3e4c253
to
bf262c5
Compare
Rebased with |
While we wait for more specific endpoints that won't require us to crawl hundreds of pages, I loaded all the agencies by state into the reducer. These are minimal agency objects with the ORI as the key and the name of the agencies
Remove old agencies file
Since the reducer is preloaded with a lightweight version of the agency representations, update the details when they come back from the API
* Refactor Sparkline components to show Loading * Add slim prop to Loading to make it thinner
jeremiak
force-pushed
the
bjs-start-ori-search
branch
from
May 23, 2017 17:23
bf262c5
to
d789b76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.