Add estimated Term to state and national overview text #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiak
commented
Jun 14, 2017
| @@ -1,7 +1,7 @@ | |||
| import PropTypes from 'prop-types' | |||
| import React from 'react' | |||
|
|
|||
| import { nibrsTerm, srsTerm } from './Terms' | |||
| import { estimatedTerm, nibrsTerm, srsTerm } from './Terms' | |||
There was a problem hiding this comment.
@RyanSibley We first want to pull in the estimated term from our Terms file. This isn't all terms, but just a few of the ones we use all the time (estimated, NIBRS, and summary at the moment).
jeremiak
commented
Jun 14, 2017
| {until} | ||
| , the FBI | ||
| {' '} | ||
| {estimatedTerm} |
There was a problem hiding this comment.
Next, we want to use that estimatedTerm variable in our text. In our current system, when you want to use a variable in some HTML you have to surround it with curly braces.
|
awesome. thank you. |
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #841