Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reimplementation of PR #162, decided after off-line discussion with @MKirchen.
From the original PR:
The current PR fixes the second issue by swapping the order of the diagnostics and the particle exchange (particle exchange first, then diagnostics). Since the particle exchange phase is always followed by a deposition of charge (including immediately after a restart, see the remark on
i_step==0
), the charge will now always be available for the diagnostics. In addition, I added a similar line for the currents (only done wheni_step==0
, not for each particle exchange).As a side-effect, note that this also takes care of the fact that the charge/currents were not deposited on the very first diagnostics (even without restart).