🐛 Fix Prefix Bulk Update #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Background: Currently, IpamPrefixesBulkUpdate() endpoint accepts single WritablePrefix object as input data. When this is used to update a prefix, Netbox returns the following error: [PUT /ipam/prefixes/][400] ipam_prefixes_bulk_update default map[non_field_errors:[Expected a list of items but got type "dict".]] Also, because it only accepts single WritablePrefix object, there is no way to bulk update using this endpoint. Fix: Replace IpamPrefixesBulkUpdate()'s input parameter to accept array of WritablePrefix. Also update its 200 response to return array of Prefixes.
|
This issue also occurs for other bulk endpoints such as get, post, patch, and delete. If this PR is approved, another set of PR's can be submitted for these endpoints. Thank you for your kind guidance and review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently,
IpamPrefixesBulkUpdate()endpoint accepts singleWritablePrefixobject as input data. When this is used to update a prefix, Netbox returns the following error:Also, because it only accepts single
WritablePrefixobject, there is no way to bulk update using this endpoint.Fix
Replace
IpamPrefixesBulkUpdate()'s input parameter to accept array ofWritablePrefix. Also update its200response to return array of Prefixes.