Skip to content

Commit

Permalink
Use _NET_WM_WINDOW_TYPE_COMBO as input window type under X11.
Browse files Browse the repository at this point in the history
Pantheon has a bug that can't not display popup window under Xwayland
twice. While the bug is reported, it's not clear when it may be fixed.
Also, input method window is indeed more like a combo box and wmspec
mentioned that it's also a common override redirect. So try to use that
instead.

Workaround #1209
  • Loading branch information
wengxt committed Dec 21, 2024
1 parent c829acf commit c0e1c7e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/ui/classic/xcbinputwindow.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ XCBInputWindow::XCBInputWindow(XCBUI *ui)
ui_->displayName(), "_KDE_NET_WM_BLUR_BEHIND_REGION", false)) {}

void XCBInputWindow::postCreateWindow() {
if (ui_->ewmh()->_NET_WM_WINDOW_TYPE_POPUP_MENU &&
if (ui_->ewmh()->_NET_WM_WINDOW_TYPE_COMBO &&
ui_->ewmh()->_NET_WM_WINDOW_TYPE) {
xcb_ewmh_set_wm_window_type(
ui_->ewmh(), wid_, 1, &ui_->ewmh()->_NET_WM_WINDOW_TYPE_POPUP_MENU);
xcb_ewmh_set_wm_window_type(ui_->ewmh(), wid_, 1,
&ui_->ewmh()->_NET_WM_WINDOW_TYPE_COMBO);
}

if (ui_->ewmh()->_NET_WM_PID) {
Expand Down

0 comments on commit c0e1c7e

Please sign in to comment.