Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize code #1133

Closed
wants to merge 1 commit into from
Closed

Optimize code #1133

wants to merge 1 commit into from

Conversation

hantengc
Copy link
Contributor

@hantengc hantengc commented Sep 20, 2024 •
edited
Loading

  1. optimize icon acquisition logic to prepare for customizing icons for other desktop environments in the future

@hantengc hantengc force-pushed the hantengc_master branch 3 times, most recently from b046402 to 4c5be0f Compare September 20, 2024 06:22
@CoelacanthusHex
Copy link

Shouldn't this thing be controlled by modifying the input-keyboard icon in the icon pack?

@hantengc
Copy link
Contributor Author

@CoelacanthusHex 1. Not sure if there are any other packages that use the input-keyboard icon, changing the system icon name will have other effects
2. In the past, I used to use icons for the KDE environment, but I think I could add icons for other desktops as well

@wengxt
Copy link
Member

wengxt commented Sep 20, 2024

I'm not sure if english us is the icon you want.

When this icon is used, it doesnt have to be English US

@hantengc
Copy link
Contributor Author

@wengxt It means that other layout input methods are also using this icon, right? Then I should have our UI designers design a more generic icon

@hantengc hantengc changed the title add UKUI desktop environment icons Optimize code Oct 12, 2024
@hantengc hantengc closed this Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hantengc @CoelacanthusHex @wengxt