-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement adding card 2 #338
Open
sumathipala-hes
wants to merge
13
commits into
fcodelabs:sudarshan
Choose a base branch
from
sumathipala-hes:Submit-new-diary-card-2
base: sudarshan
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement adding card 2 #338
sumathipala-hes
wants to merge
13
commits into
fcodelabs:sudarshan
from
sumathipala-hes:Submit-new-diary-card-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialize react project with typescript. Setup MUI.
Initialize the project.
Remove unwanted default files and created the folder structure.
Folder structure.
Implemented the Design of the the sign in page
Implemented the random nickname picking functionality.
Sign in completed
Folder name changes. Changed the avatar. Changed the font. Remove inline styling. Use local storage to save nickname. Defined routes in a separate file.
Comment on lines
+86
to
+94
|
||
// const existingEntries = JSON.parse(localStorage.getItem("diaries") || "[]"); // Get the existing entries | ||
// existingEntries.push({ title, description }); // Add the new entry to the existing entries | ||
// localStorage.setItem("diaries", JSON.stringify(existingEntries)); // Save the updated entries to local storage | ||
|
||
// setDiaries([...diaries, { title, description }]); | ||
|
||
dispatch(addDiary({ title, description })); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't commit unwanted codes
shamal-iroshan
requested changes
Dec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unwanted codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.