Extend proc.toml loader: support processes vs. tasks, retain Procfile compatibility #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends configuration parsing to distinguish between long-running processes and one-off tasks via new `[processes]` and `[tasks]` tables in `proc.toml`. Adds helpers to load process and task definitions, while preserving backward compatibility with legacy top-level layout and Procfile parsing. Introduces dedicated error handling for unavailable tasks when using only a Procfile. Includes comprehensive unit tests for new and legacy configurations. No breaking changes; existing consumers of load_config_from remain unaffected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends process configuration loading to support TOML
[processes]and[tasks]sections, cleanly separating long-running processes from one-off tasks. It retains full backward compatibility with legacy proc.toml formats and Procfile-based projects.Details
[processes]and[tasks]tables and legacy top-level process tables.load_process_configsandload_task_configs, with the latter returning a clear error if no proc.toml is available.load_config_frommethod backward-compatible for all current callers.Warning: Task VM test is not passing, cto.new will perform much better if you fix the setup