Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: https://fedora-repository.atlassian.net/browse/FCREPO-3946
What does this Pull Request do?
What's new?
OCFL 2.1.0
The dependency update for ocfl 2.1.0 were the main goal of this. This is to bring the migration validator in line with the migration-utils, which it uses when iterating over the Fedora 3 repositories.
The other dependency changes I don't believe had any changes required, with the exception of adding logback-classic in order for the slf4j update to work properly.
CI Update
I updated the ci configuration as well which had some other cascading changes. Notable adding Windows to the build matrix caused many tests to fail. Paths containing colons and other characters were one source of failure, which was resolved by URLEncoding the paths before writing (this is the same approach the migration-utils takes, though I'm not sure if it only applies it on Windows or not).
Line endings in the test data were also causing failures which was resolved by adding a
.gitattributes
. It might be better to remigrate the test data, however annoying that may be, but the attributes seem to work well enough. I had to enumerate each file and set the type tobinary
so that no attempt to change them would be made.Other changes are fairly minor, e.g. wrapping a Stream in a try-with-resources, fixing the class name for a logger, etc. Little qol things that I figured I'd get while I can.
How should this be tested?
mvn clean verify
Additional Notes:
It would be good to run this on Windows as well, I only did in on Linux against a single object dataset.
Interested parties
@fcrepo/committers