Add storage relative path to ResourceHeaders #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbpennel
reviewed
Sep 6, 2024
bbpennel
approved these changes
Sep 12, 2024
Surfrdan
pushed a commit
to Surfrdan/fcrepo-storage-ocfl
that referenced
this pull request
Jan 24, 2025
* Add storage relative path to ResourceHeaders * Modify headers before caching * Add storagerelativepath when caching from staging * Remove duplicate code
Surfrdan
pushed a commit
to Surfrdan/fcrepo-storage-ocfl
that referenced
this pull request
Feb 7, 2025
* Add storage relative path to ResourceHeaders * Modify headers before caching * Add storagerelativepath when caching from staging * Remove duplicate code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: https://fedora-repository.atlassian.net/browse/FCREPO-3935
What does this Pull Request do?
Adds the
storageRelativePathfrom theOcflObjectVersionFileto theResourceHeadersso we can pass it up to Fedora.This does not show the storage specific prefix. At this level we only have an
objectSessionand (I think) we would need the entire repository (io.ocfl.api.OcflRepository) to get the storage (io.ocfl.core.storage.OcflStorage) to get theobjectRootPath().This method also does not have a way to stop this new information from being loaded. Because of the existing functionality, it requires a second touch of the file which (I imagine) will have some performance impacts.Edit: I have moved things around to hopefully reduce duplication related to this processing.
How should this be tested?
Interested parties
Tag (@ mention) interested parties or, if unsure, @fcrepo/committers