allow interpolator to read arrays/nested #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcsonline
reviewed
Dec 17, 2022
|
Great addition! Thanks! 👏 |
|
Can you add some examples into the main readme? |
|
I just fixed some |
Bumps [qs](https://github.com/ljharb/qs) from 6.5.1 to 6.11.0. - [Release notes](https://github.com/ljharb/qs/releases) - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.5.1...v6.11.0) --- updated-dependencies: - dependency-name: qs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
kmerfeld
force-pushed
the
allow_interpolation_of_arrays
branch
from
684cbcc to
f4f2f56
Compare
Added some extra code to cover more cases in the new interpolator mechanism. Also, fixing some clippy offenses too.
|
I took the opportunity to fix some issues that I detect and also added an example in the documentation. It looks fine now! 👌 |
fcsonline
reviewed
Dec 21, 2022
| context.insert(String::from("Array"), json!(["a", "b", "c"])); | ||
| context.insert(String::from("Object"), json!({"this": "that"})); | ||
| context.insert(String::from("Nested"), json!({"this": {"that": {"those": [{"wow": 1}, {"so": 2}, {"deee": {"eeee": "eeep"}}]}}})); | ||
| context.insert(String::from("ArrayNested"), json!([{"a": [{}, {"aa": 2, "aaa": [{"aaaa": 123 }]}]}])); |
There was a problem hiding this comment.
This was not working properly.
|
Merging! Thanks for this great contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix #102