You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
convertMatchListToRegExp() removes all flags as it uses the RegExp.source property (see utilities-data.ts line 47)
Not so easy to define what should be the correct behavior but I would advocate that the 'i' flag is very useful ;)
BTW the 'g' flag is not useful as css-selector-generator only tests the RegExp..
Why not setting a 'i' flag if at least one of the RegExp of the list defines it ?
I can make the PR if your want to.
Regards
The text was updated successfully, but these errors were encountered:
Is it faster than creating one main big RegExp expression ?
It is not possible to create a single RegExp that will use different flags for parts of the expression. So that's not even an option. Anyway, I don't think it really matters in this case, as the volume of checked items is quite small. So the performance in common situations should be practically the same (almost zero).
convertMatchListToRegExp() removes all flags as it uses the RegExp.source property (see utilities-data.ts line 47)
Not so easy to define what should be the correct behavior but I would advocate that the 'i' flag is very useful ;)
BTW the 'g' flag is not useful as css-selector-generator only tests the RegExp..
Why not setting a 'i' flag if at least one of the RegExp of the list defines it ?
I can make the PR if your want to.
Regards
The text was updated successfully, but these errors were encountered: