Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use updated state after poll #109

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Change to use updated state after poll #109

merged 1 commit into from
Mar 29, 2019

Conversation

vlovgr
Copy link
Contributor

@vlovgr vlovgr commented Mar 29, 2019

In #106 we changed to run rebalance listeners as part of poll, but forgot to change to use the updated state after poll, and we were still relying on the previous state.

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #109 into master will increase coverage by <.01%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   98.01%   98.01%   +<.01%     
==========================================
  Files          38       38              
  Lines        1006     1007       +1     
  Branches       56       57       +1     
==========================================
+ Hits          986      987       +1     
  Misses         20       20
Impacted Files Coverage Δ
.../scala/fs2/kafka/internal/KafkaConsumerActor.scala 94.63% <90.9%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c32bf6...6d471f7. Read the comment docs.

@vlovgr vlovgr merged commit ec3d3ce into master Mar 29, 2019
@vlovgr vlovgr deleted the new-state-poll branch March 29, 2019 07:39
@backuitist
Copy link
Contributor

Yeah that state variable got me puzzled. Good that it's gone :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants