Change default auto.offset.reset to none #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlovgr
force-pushed
the
auto-offset-reset-none
branch
from
9476d46 to
7a51478
Compare
Codecov Report
@@ Coverage Diff @@
## 0.20.x #121 +/- ##
==========================================
+ Coverage 93.55% 93.56% +0.01%
==========================================
Files 40 40
Lines 1211 1213 +2
Branches 83 84 +1
==========================================
+ Hits 1133 1135 +2
Misses 78 78
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## 0.20.x #121 +/- ##
==========================================
+ Coverage 93.55% 93.56% +0.01%
==========================================
Files 40 40
Lines 1211 1213 +2
Branches 83 84 +1
==========================================
+ Hits 1133 1135 +2
Misses 78 78
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java Kafka consumer defaults
auto.offset.resettolatest, which can be surprising. We therefore set the default tonone, which means an error will be raised if there are no offsets for the consumer group, and the user can then decide what the appropriate setting is for their use case.