Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to parameterize AdminClientSettings on effect type #125

Merged
merged 1 commit into from
May 3, 2019

Conversation

vlovgr
Copy link
Contributor

@vlovgr vlovgr commented May 3, 2019

Similarly to #118 and #120, this pull request parameterizes AdminClientSettings on the effect type F[_], requiring Sync[F].

Detailed changes as follows.

  • Remove AdminClientFactory.
  • Add createAdminClient and withCreateAdminClient to AdminClientSettings.
  • Replace AdminClientSettings.Default with apply (use AdminClientSettings[F]).
  • Remove adminClientFactory and withAdminClientFactory from AdminClientSettings.
  • Change to parameterize AdminClientSettings on the effect type F[_], requiring Sync[F].

@vlovgr vlovgr force-pushed the admin-client-settings-effect branch from 0bdcef3 to d14dd52 Compare May 3, 2019 15:09
@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #125 into 0.20.x will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.20.x     #125      +/-   ##
==========================================
- Coverage   93.37%   93.35%   -0.02%     
==========================================
  Files          41       40       -1     
  Lines        1177     1174       -3     
  Branches       79       80       +1     
==========================================
- Hits         1099     1096       -3     
  Misses         78       78
Impacted Files Coverage Δ
src/main/scala/fs2/kafka/package.scala 100% <ø> (ø) ⬆️
src/main/scala/fs2/kafka/KafkaAdminClient.scala 100% <ø> (ø) ⬆️
src/main/scala/fs2/kafka/AdminClientSettings.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abfd171...d14dd52. Read the comment docs.

@vlovgr vlovgr merged commit 8400d62 into 0.20.x May 3, 2019
@vlovgr vlovgr deleted the admin-client-settings-effect branch May 3, 2019 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant