-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support consumer offsets for times and list topics #1285
Support consumer offsets for times and list topics #1285
Conversation
@vlovgr @bplommer @aartigao I'm not sure who the correct people to tag for this would be, but I was wondering if this functionality could be reviewed/added. I have a project that is trying to use fs2-kafka and needs the offsets for times functionality. Please let me know if you are not the correct people. |
Hey, probably next week I can take a look! (quite busy these days with the newborn and all the celebrations...) |
Thanks! No worries. Happy New Year :) |
CI is not passing for Scala 2.12. Please, add a compatibility converter for it in |
…s2-kafka into support-more-topis-operations
I replaced the usage with something that works for all scala versions. The ci should hopefully be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…s2-kafka into support-more-topis-operations
@aartigao Sorry. Had to fix an imports issue in a test, and updated a case to handle nulls more appropriately. Thanks for reviewing. |
c981378
to
2b5efcd
Compare
@cwholmes Can you run After that, if you don't have more changes, I'd be more than happy to merge it and build a release 🚀 |
…s2-kafka into support-more-topis-operations
It seems the files I added needed the dates on the headers updated. I have added that and things should be working again. |
Thanks for the contribution! ;) |
This change adds functionality for the consumer for
offsetsForTimes
andlistTopics
. These are part of #94.