Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #129 #194

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Revert #129 #194

merged 1 commit into from
Aug 30, 2019

Conversation

vlovgr
Copy link
Contributor

@vlovgr vlovgr commented Aug 29, 2019

It seems the assumption made in #129 is incorrect: poll(timeout) with timeout > 0 can both result in assignment and new records being returned for the new assignment. Therefore, we generally need to store records before fetch requests are received. This pull request effectively reverts #129.

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #194 into master will decrease coverage by 0.23%.
The diff coverage is 76.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   91.86%   91.62%   -0.24%     
==========================================
  Files          57       57              
  Lines        1376     1397      +21     
  Branches       54       54              
==========================================
+ Hits         1264     1280      +16     
- Misses        112      117       +5
Impacted Files Coverage Δ
...e/src/main/scala/fs2/kafka/internal/LogEntry.scala 26.47% <0%> (+1.47%) ⬆️
.../scala/fs2/kafka/internal/KafkaConsumerActor.scala 84.07% <78.94%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b78ee1...8a5153e. Read the comment docs.

@vlovgr vlovgr merged commit de3d231 into master Aug 30, 2019
@vlovgr vlovgr deleted the revert-129 branch August 30, 2019 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant