-
Notifications
You must be signed in to change notification settings - Fork 487
Conversation
That's a nice addition but to be honest I'm a bit hesitant about adding another backend. Are there any feature that potential users may only be able to use with this new backend ? |
39ef02c
to
fc19c26
Compare
I understand your hesitation to keep adding backends, however I think pancurses would be worthwhile. For me two reasons stand out:
In summary, while I know the crossterm devs are working hard on filling in the gaps (e.g. input handling) the pancurses backend already offers full Windows functionality plus a few goodies that will be useful even as crossterm gets more mature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good. I've just pushed a change on how the demo examples are organized in order to be able to reuse most of the UI and app state code for all available backends. Could you update the curses_demo to follow this pattern ? With this change, I've also removed the additional backend example so I think you could do the same here.
fc19c26
to
c281734
Compare
I just pushed the changes, curses_demo now uses the shared ui / app code and I've removed the standalone curses example. See comment on change request for changes to the backend instantiation. |
LGTM, thanks for taking the time to work on this and for being patient enough with my delayed reviews =) |
On Unix I don't see a reason not to use termion, but on Windows pancurses adds the PDcurses backend which works quite nicely. (Plus you get Unix ncurses for free, however without Unicode).