This repository has been archived by the owner on Aug 6, 2023. It is now read-only.
feat(widgets/paragraph): improve scrolling #349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional callback to `Wrap` to compute the scroll offsets given the wrapped lines. This let users compute the offsets dynamically.
fdehau
force-pushed
the
paragraph-scroll
branch
from
edbfd5a
to
54b841f
Compare
ClementTsang
added a commit
to ClementTsang/bottom
that referenced
this pull request
Aug 12, 2020
This also slightly improves how we generate the widths/heights to be less... terrible. Note this is not done, unfortunately. This requires tui-rs' wrapped paragraph height PR to land and release so I can properly calculate the height offsets. See fdehau/tui-rs#349 for details.
|
@fdehau are there any blockers for this PR? |
|
@fdehau any plans on merging this? this would be quite nice to have so that workarounds with list can be avoided |
|
trying to bump this pr 😞 |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional callback to
Wrapto compute the scroll offsets given the wrapped lines. This letusers compute the offsets dynamically.