Fix sensu data source reporting errors when using a server filter on a working server #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rn an error code if the given server has no errors in the event list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, here's another one for you :)
The previous implementation of the sensu data source would return an error if you specified a server filter but the event list didn't contain any events from that server (master on line 60). In this state you actually want a "green" result because it means there are no errors on that server.
I did some refactoring of the code as well. I'm not a Ruby programmer so I have a feeling there are some non-Ruby-ific style in there. Also, I tried to test all of the cases and I think they all work (e.g. with/without server filter, with/without event filter, etc.).
Give this one a thorough review before accepting it.