chore: update ssh-key format in tests to match real-world usage #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7flying
changed the title
nullr0ute
reviewed
Jun 28, 2023
oh, I did not know that, will update this accordingly, thanks 👍 |
Signed-off-by: Irene Diez <idiez@redhat.com>
Our FSIM for creating users with an associated ssh key did not take into account that ssh keys are strings that may have spaces, e.g. 'ssh-ed25519 long-string user@example.com', and used ' ' as the split character. This sets ';' as the split character in the FSIM avoiding installing unusable ssh keys. Fixes rhbz#2218231. Signed-off-by: Irene Diez <idiez@redhat.com>
|
@nullr0ute sorry about the dismissed review, I ended up fixing the BZ also in this PR |
|
Linking #507 for awareness |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to reproduce RHBZ#2218231 (and to catch more related bugs in the future)
and it also fixes that same BZ.
Our FSIM for creating users with an associated ssh key did
not take into account that ssh keys are strings that may
have spaces, e.g. 'ssh-ed25519 long-string user@example.com',
and used ' ' as the split character.
This sets ';' as the split character in the FSIM avoiding
installing unusable ssh keys.