Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rofimoji a modus of roji #44

Closed
gfarrell opened this issue Jul 8, 2020 · 12 comments
Closed

Make rofimoji a modus of roji #44

gfarrell opened this issue Jul 8, 2020 · 12 comments

Comments

@gfarrell
Copy link

gfarrell commented Jul 8, 2020

There are many rofi plugins (e.g. rofi-calc) which can be invoked as modi within rofi. This is preferred for me, as I'm sure like many other people I have a key combination (super+d) bound to rofi, and would rather not have another one just to invoke rofimoji (and would also rather not have to open a terminal just to start it).

Would it be possible to package this in such a way as to make it a rofi modus?

@fdw
Copy link
Owner

fdw commented Jul 8, 2020

This has been suggested and thought about before (#24), and I still like the idea, but I cannot see a reasonableway to do this. At the least, rofimoji would use all custom keybindings while having a higher internal complexity to keep track of stuff.

So, if you want to try or have any ideas to make it easier, I'm very open, but I'm not too hopeful, sorry.

@gfarrell
Copy link
Author

gfarrell commented Jul 8, 2020

Hmm I see. There is a rofi-emoji plugin which seems to make it work, but I guess it's a simpler tool.

@gfarrell gfarrell closed this as completed Jul 8, 2020
@fdw
Copy link
Owner

fdw commented Jul 8, 2020

Maybe I'll have another go at it, we'll see ;)

@fdw
Copy link
Owner

fdw commented Jan 1, 2021

I had a go at this, and you can see the result on the test-mode branch.
The code needs some polish, but I think the functionality is as good as it can get - which is to say, not ideal. From the readme:

You cannot directly type the chosen character. You can only copy it to the clipboard.
You can only select one character at a time.
The custom keyboard shortcuts are still there, but mapped to Alt+Shift+1 (on a Qwerty keyboard) etc.

If you are still interested in this, please test it and give me feedback!

(also paging @farzadmf from #24)

@fdw fdw reopened this Jan 1, 2021
@fdw fdw mentioned this issue Jan 1, 2021
@fdw
Copy link
Owner

fdw commented Jan 30, 2021

Is there still interest in this? Did anyone have a look at it?

@gfarrell
Copy link
Author

Hi @fdw -- I've been using the rofi-emoji plugin but I tried this:

git clone git@github.com:fdw/rofimoji.git
cd rofimoji
python3 setup.py build
sudo python3 setup.py install
rofi -modi "rofimoji:/home/gideon/sandbox/rofimoji/build/lib/picker/rofimoji.py" -show rofimoji

It works, I get a searchable list of emoji, when I hit "enter" I get a skin tone selector, but when I hit enter one more time I get this:

rofi

Pressing enter from here does nothing.

@fdw
Copy link
Owner

fdw commented Jan 30, 2021

Thanks!

Apparently, I left some debugging code lying around 🤦. Please try again, it should work now.

@gfarrell
Copy link
Author

Ok I think that works now!

@gfarrell
Copy link
Author

Will you be doing an updated release so we can get it into the AUR?

@fdw
Copy link
Owner

fdw commented Jan 31, 2021

Thank you!
The plan is to have a new release soon, but I want to have another look at the code first. Depending on how confident I am, it might first just be a RC.

fdw added a commit that referenced this issue Jan 31, 2021
A much requested feature was to be able to run `rofimoji` as a rofi
"mode". With this, you could, for example, have a combi mode with
different character sets.

However, rofi unfortunately (and sometimes understandably) limits the
features of its modes. The most annoying is that you cannot call
`xdotool` to type into another window. So with the mode, the best you
can do is to copy to the clipboard.
Secondly, all the custom shortcut mappings are gone, and we must use the
default ones which are not easy to remember.
Finally, selecting more than one character is also impossible.

Is it worth it? I'm not sure, but we can try.

Issue: #44
@fdw
Copy link
Owner

fdw commented Feb 20, 2021

This is now released! 🎉

@fdw fdw closed this as completed Feb 20, 2021
@gfarrell
Copy link
Author

gfarrell commented Feb 20, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants