Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rofimoji only copies one emoji to clipboard #6

Closed
rixx opened this issue Jan 23, 2019 · 4 comments
Closed

rofimoji only copies one emoji to clipboard #6

rixx opened this issue Jan 23, 2019 · 4 comments

Comments

@rixx
Copy link

rixx commented Jan 23, 2019

When selecting multiple emoji, only one emoji is copied to my clipboard – It seems you're copying each emoji individually, overriding the previously copied emoji.
fdw added a commit that referenced this issue Jan 24, 2019
@fdw
Fix copying multiple emojis
2caf447 
You can't just overwrite the selection every time and expect it to work.

Issue: #6
@fdw
Copy link
Owner

fdw commented Jan 24, 2019

Hi @rixx, you're right, that couldn't have worked. Why did I do this? 🤦‍♂️

I pushed a fix to fix/copy-multiple. I think it works now, but it would be nice if you could also check before I merge. Thank you!

@rixx
Copy link
Author

rixx commented Jan 24, 2019

Looks good to me, thank you!

@fdw
Copy link
Owner

fdw commented Jan 25, 2019

Thank you!

Merged & published.

@fdw fdw closed this as completed Jan 25, 2019
@HaleTom
Copy link

HaleTom commented Jan 20, 2022

For Googlers, try pressing Shift+Enter to copy multiple emojis :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rixx @fdw @HaleTom