Skip to content

Commit

Permalink
hold
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-madkins committed Dec 23, 2022
1 parent 0c0d468 commit 1a99376
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 39 deletions.
76 changes: 38 additions & 38 deletions sdk/python/feast/infra/registry/proto_registry_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ def get_feature_service(
) -> FeatureService:
for feature_service_proto in registry_proto.feature_services:
if (
feature_service_proto.spec.project == project
and feature_service_proto.spec.name == name
feature_service_proto.spec.name == name
#and feature_service_proto.spec.project == project
):
return FeatureService.from_proto(feature_service_proto)
raise FeatureServiceNotFoundException(name, project=project)
Expand All @@ -39,7 +39,7 @@ def get_feature_view(
for feature_view_proto in registry_proto.feature_views:
if (
feature_view_proto.spec.name == name
and feature_view_proto.spec.project == project
#and feature_view_proto.spec.project == project
):
return FeatureView.from_proto(feature_view_proto)
raise FeatureViewNotFoundException(name, project)
Expand All @@ -51,7 +51,7 @@ def get_stream_feature_view(
for feature_view_proto in registry_proto.stream_feature_views:
if (
feature_view_proto.spec.name == name
and feature_view_proto.spec.project == project
#and feature_view_proto.spec.project == project
):
return StreamFeatureView.from_proto(feature_view_proto)
raise FeatureViewNotFoundException(name, project)
Expand All @@ -61,7 +61,7 @@ def get_request_feature_view(registry_proto: RegistryProto, name: str, project:
for feature_view_proto in registry_proto.feature_views:
if (
feature_view_proto.spec.name == name
and feature_view_proto.spec.project == project
#and feature_view_proto.spec.project == project
):
return RequestFeatureView.from_proto(feature_view_proto)
raise FeatureViewNotFoundException(name, project)
Expand All @@ -72,8 +72,8 @@ def get_on_demand_feature_view(
) -> OnDemandFeatureView:
for on_demand_feature_view in registry_proto.on_demand_feature_views:
if (
on_demand_feature_view.spec.project == project
and on_demand_feature_view.spec.name == name
on_demand_feature_view.spec.name == name
#and on_demand_feature_view.spec.project == project
):
return OnDemandFeatureView.from_proto(on_demand_feature_view)
raise OnDemandFeatureViewNotFoundException(name, project=project)
Expand All @@ -83,14 +83,14 @@ def get_data_source(
registry_proto: RegistryProto, name: str, project: str
) -> DataSource:
for data_source in registry_proto.data_sources:
if data_source.project == project and data_source.name == name:
if data_source.name == name:# and data_source.project == project:
return DataSource.from_proto(data_source)
raise DataSourceObjectNotFoundException(name, project=project)


def get_entity(registry_proto: RegistryProto, name: str, project: str) -> Entity:
for entity_proto in registry_proto.entities:
if entity_proto.spec.name == name and entity_proto.spec.project == project:
if entity_proto.spec.name == name:# and entity_proto.spec.project == project:
return Entity.from_proto(entity_proto)
raise EntityNotFoundException(name, project=project)

Expand All @@ -99,7 +99,7 @@ def get_saved_dataset(
registry_proto: RegistryProto, name: str, project: str
) -> SavedDataset:
for saved_dataset in registry_proto.saved_datasets:
if saved_dataset.spec.name == name and saved_dataset.spec.project == project:
if saved_dataset.spec.name == name:# and saved_dataset.spec.project == project:
return SavedDataset.from_proto(saved_dataset)
raise SavedDatasetNotFound(name, project=project)

Expand All @@ -110,7 +110,7 @@ def get_validation_reference(
for validation_reference in registry_proto.validation_references:
if (
validation_reference.name == name
and validation_reference.project == project
#and validation_reference.project == project
):
return ValidationReference.from_proto(validation_reference)
raise ValidationReferenceNotFound(name, project=project)
Expand All @@ -121,8 +121,8 @@ def list_feature_services(
) -> List[FeatureService]:
feature_services = []
for feature_service_proto in registry_proto.feature_services:
if feature_service_proto.spec.project == project:
feature_services.append(FeatureService.from_proto(feature_service_proto))
#if feature_service_proto.spec.project == project:
feature_services.append(FeatureService.from_proto(feature_service_proto))
return feature_services


Expand All @@ -131,8 +131,8 @@ def list_feature_views(
) -> List[FeatureView]:
feature_views: List[FeatureView] = []
for feature_view_proto in registry_proto.feature_views:
if feature_view_proto.spec.project == project:
feature_views.append(FeatureView.from_proto(feature_view_proto))
#if feature_view_proto.spec.project == project:
feature_views.append(FeatureView.from_proto(feature_view_proto))
return feature_views


Expand All @@ -141,10 +141,10 @@ def list_request_feature_views(
) -> List[RequestFeatureView]:
feature_views: List[RequestFeatureView] = []
for request_feature_view_proto in registry_proto.request_feature_views:
if request_feature_view_proto.spec.project == project:
feature_views.append(
RequestFeatureView.from_proto(request_feature_view_proto)
)
#if request_feature_view_proto.spec.project == project:
feature_views.append(
RequestFeatureView.from_proto(request_feature_view_proto)
)
return feature_views


Expand All @@ -153,10 +153,10 @@ def list_stream_feature_views(
) -> List[StreamFeatureView]:
stream_feature_views = []
for stream_feature_view in registry_proto.stream_feature_views:
if stream_feature_view.spec.project == project:
stream_feature_views.append(
StreamFeatureView.from_proto(stream_feature_view)
)
#if stream_feature_view.spec.project == project:
stream_feature_views.append(
StreamFeatureView.from_proto(stream_feature_view)
)
return stream_feature_views


Expand All @@ -165,26 +165,26 @@ def list_on_demand_feature_views(
) -> List[OnDemandFeatureView]:
on_demand_feature_views = []
for on_demand_feature_view in registry_proto.on_demand_feature_views:
if on_demand_feature_view.spec.project == project:
on_demand_feature_views.append(
OnDemandFeatureView.from_proto(on_demand_feature_view)
)
#if on_demand_feature_view.spec.project == project:
on_demand_feature_views.append(
OnDemandFeatureView.from_proto(on_demand_feature_view)
)
return on_demand_feature_views


def list_entities(registry_proto: RegistryProto, project: str) -> List[Entity]:
entities = []
for entity_proto in registry_proto.entities:
if entity_proto.spec.project == project:
entities.append(Entity.from_proto(entity_proto))
#if entity_proto.spec.project == project:
entities.append(Entity.from_proto(entity_proto))
return entities


def list_data_sources(registry_proto: RegistryProto, project: str) -> List[DataSource]:
data_sources = []
for data_source_proto in registry_proto.data_sources:
if data_source_proto.project == project:
data_sources.append(DataSource.from_proto(data_source_proto))
#if data_source_proto.project == project:
data_sources.append(DataSource.from_proto(data_source_proto))
return data_sources


Expand All @@ -193,8 +193,8 @@ def list_saved_datasets(
) -> List[SavedDataset]:
saved_datasets = []
for saved_dataset in registry_proto.saved_datasets:
if saved_dataset.project == project:
saved_datasets.append(SavedDataset.from_proto(saved_dataset))
#if saved_dataset.project == project:
saved_datasets.append(SavedDataset.from_proto(saved_dataset))
return saved_datasets


Expand All @@ -203,10 +203,10 @@ def list_validation_reference(
) -> List[ValidationReference]:
validation_references = []
for validation_reference in registry_proto.validation_references:
if validation_reference.project == project:
validation_references.append(
ValidationReference.from_proto(validation_reference)
)
#if validation_reference.project == project:
validation_references.append(
ValidationReference.from_proto(validation_reference)
)
return validation_references


Expand All @@ -216,5 +216,5 @@ def list_project_metadata(
return [
ProjectMetadata.from_proto(project_metadata)
for project_metadata in registry_proto.project_metadata
if project_metadata.project == project
#if project_metadata.project == project
]
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/registry/snowflake.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def __init__(
else 0
)

def refresh(self, project: Optional[str]):
def refresh(self):
self.cached_registry_proto = self.proto()
self.cached_registry_proto_created = datetime.utcnow()

Expand Down

0 comments on commit 1a99376

Please sign in to comment.