Skip to content

Commit

Permalink
fix: Add check for bool type in addition to sample (#3452)
Browse files Browse the repository at this point in the history
fix: add check for bool type in addition to sample

Signed-off-by: Ryan Beauchamp <ryan.beauchamp@ezcater.com>

Signed-off-by: Ryan Beauchamp <ryan.beauchamp@ezcater.com>
  • Loading branch information
beauchbum authored Jan 20, 2023
1 parent 2f7c4ed commit 1c7c491
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sdk/python/feast/type_map.py
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ def _python_value_to_proto_value(
valid_scalar_types,
) = PYTHON_SCALAR_VALUE_TYPE_TO_PROTO_VALUE[feast_value_type]
if valid_scalar_types:
if sample == 0 or sample == 0.0:
if (sample == 0 or sample == 0.0) and feast_value_type != ValueType.BOOL:
# Numpy convert 0 to int. However, in the feature view definition, the type of column may be a float.
# So, if value is 0, type validation must pass if scalar_types are either int or float.
assert type(sample) in [np.int64, int, np.float64, float]
Expand Down

0 comments on commit 1c7c491

Please sign in to comment.