Skip to content

Commit

Permalink
Fix issues with lint test and upgrade pip version (#1964)
Browse files Browse the repository at this point in the history
  • Loading branch information
felixwang9817 authored Oct 22, 2021
1 parent ec4c02b commit 3b5ea8f
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 4 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ jobs:
aws-region: us-west-2
- name: Use AWS CLI
run: aws sts get-caller-identity
- name: Upgrade pip version
run: |
pip install --upgrade "pip>=21.3.1"
- name: Get pip cache dir
id: pip-cache
run: |
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ jobs:
with:
python-version: "3.7"
architecture: x64
- name: Upgrade pip version
run: |
pip install --upgrade "pip>=21.3.1"
- name: Get pip cache dir
id: pip-cache
run: |
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/pr_integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ jobs:
aws-region: us-west-2
- name: Use AWS CLI
run: aws sts get-caller-identity
- name: Upgrade pip version
run: |
pip install --upgrade "pip>=21.3.1"
- name: Get pip cache dir
id: pip-cache
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ jobs:
with:
python-version: ${{ matrix.python-version }}
architecture: x64
- name: Downgrade pip
- name: Upgrade pip version
run: |
pip install --upgrade "pip<21.3"
pip install --upgrade "pip>=21.3.1"
- name: Get pip cache dir
id: pip-cache
run: |
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/gcp.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class GCSRegistryStore(RegistryStore):
def __init__(self, registry_config: RegistryConfig, repo_path: Path):
uri = registry_config.path
try:
from google.cloud import storage
import google.cloud.storage as storage
except ImportError as e:
from feast.errors import FeastExtrasDependencyImportError

Expand All @@ -34,7 +34,7 @@ def __init__(self, registry_config: RegistryConfig, repo_path: Path):
self._blob = self._uri.path.lstrip("/")

def get_registry_proto(self):
from google.cloud import storage
import google.cloud.storage as storage
from google.cloud.exceptions import NotFound

file_obj = TemporaryFile()
Expand Down

0 comments on commit 3b5ea8f

Please sign in to comment.