Online serving optimizations (#1286)

* optimize online serving Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com> * format Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com> * distinct feature references Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com> * refactor spec cache Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com> * format Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com> * fix tests Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com> * feature not found in spec Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com> * add java options to feast-serving helm chart Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com> * delete duplicating java options Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
feast-dev · Jan 28, 2021 · 3fabae0 · 3fabae0
1 parent 2cc2f3d
commit 3fabae0
Show file tree

Hide file tree

Showing 13 changed files with 275 additions and 201 deletions.
diff --git a/common-test/src/main/java/feast/common/it/DataGenerator.java b/common-test/src/main/java/feast/common/it/DataGenerator.java
@@ -134,6 +134,19 @@ public static FeatureTableSpec createFeatureTableSpec(
                             .build())
                 .collect(Collectors.toList()))
         .setMaxAge(Duration.newBuilder().setSeconds(3600).build())
+        .setBatchSource(
+            DataSource.newBuilder()
+                .setEventTimestampColumn("ts")
+                .setType(DataSource.SourceType.BATCH_FILE)
+                .setFileOptions(
+                    FileOptions.newBuilder()
+                        .setFileFormat(
+                            FileFormat.newBuilder()
+                                .setParquetFormat(ParquetFormat.newBuilder().build())
+                                .build())
+                        .setFileUrl("/dev/null")
+                        .build())
+                .build())
         .putAllLabels(labels)
         .build();
   }

diff --git a/core/src/test/java/feast/core/service/SpecServiceIT.java b/core/src/test/java/feast/core/service/SpecServiceIT.java
@@ -659,6 +659,7 @@ public void shouldErrorOnMissingBatchSource() {
                   3600,
                   Map.of())
               .toBuilder()
+              .clearBatchSource()
               .build();
 
       StatusRuntimeException exc =

diff --git a/infra/charts/feast/charts/feast-serving/templates/deployment.yaml b/infra/charts/feast/charts/feast-serving/templates/deployment.yaml
@@ -117,7 +117,11 @@ spec:
         {{- if .Values.livenessProbe.enabled }}
         livenessProbe:
           exec:
-            command: ["grpc-health-probe", "-addr=:{{ .Values.service.grpc.targetPort }}"]
+            command:
+            - "grpc-health-probe"
+            - "-addr=:{{ .Values.service.grpc.targetPort }}"
+            - "-connect-timeout={{ .Values.livenessProbe.timeoutSeconds }}s"
+            - "-rpc-timeout={{ .Values.livenessProbe.timeoutSeconds }}s"
           initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds }}
           periodSeconds: {{ .Values.livenessProbe.periodSeconds }}
           successThreshold: {{ .Values.livenessProbe.successThreshold }}
@@ -128,7 +132,11 @@ spec:
         {{- if .Values.readinessProbe.enabled }}
         readinessProbe:
           exec:
-            command: ["grpc-health-probe", "-addr=:{{ .Values.service.grpc.targetPort }}"]
+            command:
+            - "grpc-health-probe"
+            - "-addr=:{{ .Values.service.grpc.targetPort }}"
+            - "-connect-timeout={{ .Values.readinessProbe.timeoutSeconds }}s"
+            - "-rpc-timeout={{ .Values.readinessProbe.timeoutSeconds }}s"
           initialDelaySeconds: {{ .Values.readinessProbe.initialDelaySeconds }}
           periodSeconds: {{ .Values.readinessProbe.periodSeconds }}
           successThreshold: {{ .Values.readinessProbe.successThreshold }}

diff --git a/infra/docker/serving/Dockerfile b/infra/docker/serving/Dockerfile
@@ -42,12 +42,12 @@ RUN wget -q https://github.com/grpc-ecosystem/grpc-health-probe/releases/downloa
 # Build stage 2: Production
 # ============================================================
 
-FROM openjdk:11-jre-slim as production
+FROM amazoncorretto:11 as production
 ARG VERSION=dev
 COPY --from=builder /build/serving/target/feast-serving-$VERSION-exec.jar /opt/feast/feast-serving.jar
 COPY --from=builder /usr/bin/grpc-health-probe /usr/bin/grpc-health-probe
 CMD ["java",\
-     "-Xms1024m",\
-     "-Xmx1024m",\
+     "-Xms1g",\
+     "-Xmx4g",\
      "-jar",\
      "/opt/feast/feast-serving.jar"]
diff --git a/serving/pom.xml b/serving/pom.xml
@@ -298,13 +298,13 @@
     <dependency>
       <groupId>org.testcontainers</groupId>
       <artifactId>testcontainers</artifactId>
-      <version>1.14.3</version>
+      <version>1.15.1</version>
       <scope>test</scope>
     </dependency>
     <dependency>
       <groupId>org.testcontainers</groupId>
       <artifactId>junit-jupiter</artifactId>
-      <version>1.14.3</version>
+      <version>1.15.1</version>
       <scope>test</scope>
     </dependency>
     <dependency>