Skip to content

Commit

Permalink
fix: Remove redis service to prevent more conflicts and add redis nod…
Browse files Browse the repository at this point in the history
…e to master_only (#2354)

* Fix redis on master.yml

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

* Remove hack in make_feature_store_yaml

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

* Fix error

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

* Fix tests

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
kevjumba authored and adchia committed Mar 4, 2022
1 parent 003819b commit 43a1bd4
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 12 deletions.
15 changes: 5 additions & 10 deletions .github/workflows/master_only.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,16 +65,6 @@ jobs:
env:
OS: ${{ matrix.os }}
PYTHON: ${{ matrix.python-version }}
services:
redis:
image: redis
ports:
- 6379:6379
options: >-
--health-cmd "redis-cli ping"
--health-interval 10s
--health-timeout 5s
--health-retries 5
steps:
- uses: actions/checkout@v2
- name: Setup Python
Expand Down Expand Up @@ -120,6 +110,11 @@ jobs:
run: pip install pip-tools
- name: Install dependencies
run: make install-python-ci-dependencies
- name: Start Redis
uses: supercharge/redis-github-action@1.4.0
with:
redis-version: ${{ matrix.redis-version }}
redis-port: 12345
- name: Setup Redis Cluster
run: |
docker pull vishnunair/docker-redis-cluster:latest
Expand Down
6 changes: 4 additions & 2 deletions sdk/python/tests/integration/registration/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,11 @@ def make_feature_store_yaml(project, test_repo_config, repo_dir_name: Path):
isinstance(config_dict["online_store"], dict)
and "redis_type" in config_dict["online_store"]
):
del config_dict["online_store"]["redis_type"]
if str(config_dict["online_store"]["redis_type"]) == "RedisType.redis_cluster":
config_dict["online_store"]["redis_type"] = "redis_cluster"
elif str(config_dict["online_store"]["redis_type"]) == "RedisType.redis":
config_dict["online_store"]["redis_type"] = "redis"
config_dict["repo_path"] = str(config_dict["repo_path"])

return yaml.safe_dump(config_dict)


Expand Down

0 comments on commit 43a1bd4

Please sign in to comment.