fix: Add description attribute to the Field.from_proto method (#3469)

* fix: Add description attribute to the from_proto method Signed-off-by: gbmarc1 <marcantoine.belanger@shopify.com> * lint Signed-off-by: Danny Chiao <danny@tecton.ai> --------- Signed-off-by: gbmarc1 <marcantoine.belanger@shopify.com> Signed-off-by: Danny Chiao <danny@tecton.ai> Co-authored-by: Danny Chiao <danny@tecton.ai>
feast-dev · Feb 3, 2023 · 473f8d9 · 473f8d9
1 parent d3b7c06
commit 473f8d9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/sdk/python/feast/field.py b/sdk/python/feast/field.py
@@ -109,6 +109,7 @@ def from_proto(cls, field_proto: FieldProto):
             name=field_proto.name,
             dtype=from_value_type(value_type=value_type),
             tags=dict(field_proto.tags),
+            description=field_proto.description,
         )
 
     @classmethod

diff --git a/sdk/python/tests/unit/test_feature.py b/sdk/python/tests/unit/test_feature.py
@@ -27,3 +27,6 @@ def test_field_serialization_with_description():
 
     assert serialized_field.description == expected_description
     assert field_from_feature.description == expected_description
+
+    field = Field.from_proto(serialized_field)
+    assert field.description == expected_description