Skip to content

Commit

Permalink
Remove underscores from ECR docker versions (#2139)
Browse files Browse the repository at this point in the history
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
achals authored Dec 14, 2021
1 parent 59031ca commit 5560caf
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
10 changes: 3 additions & 7 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -146,16 +146,12 @@ push-ci-docker:
build-ci-docker:
docker build -t $(REGISTRY)/feast-ci:$(VERSION) -f infra/docker/ci/Dockerfile .

# Note, we use underscores instead of periods in the version name since ECR doesn't support periods. We automatically
# pull from Docker Hub and push to ECR.
push-feature-server-python-aws-docker:
ECR_VERSION=$(shell echo "$(VERSION)" | sed 's/[.]/_/g'); \
docker push $(REGISTRY)/feature-server-python-aws:$$ECR_VERSION
docker push $(REGISTRY)/feature-server-python-aws:$$VERSION

build-feature-server-python-aws-docker:
ECR_VERSION=$(shell echo "$(VERSION)" | sed 's/[.]/_/g'); \
docker build --build-arg VERSION=$$ECR_VERSION \
-t $(REGISTRY)/feature-server-python-aws:$$ECR_VERSION \
docker build --build-arg VERSION=$$VERSION \
-t $(REGISTRY)/feature-server-python-aws:$$VERSION \
-f sdk/python/feast/infra/feature_servers/aws_lambda/Dockerfile .

push-feature-transformation-server-docker:
Expand Down
3 changes: 2 additions & 1 deletion infra/templates/README.md.jinja2
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
<br />

[![unit-tests](https://github.com/feast-dev/feast/actions/workflows/unit_tests.yml/badge.svg?branch=master&event=push)](https://github.com/feast-dev/feast/actions/workflows/unit_tests.yml)
[![integration-tests](https://github.com/feast-dev/feast/actions/workflows/integration_tests.yml/badge.svg?branch=master&event=push)](https://github.com/feast-dev/feast/actions/workflows/integration_tests.yml)
[![integration-tests-and-build](https://github.com/feast-dev/feast/actions/workflows/master_only.yml/badge.svg?branch=master&event=push)](https://github.com/feast-dev/feast/actions/workflows/master_only.yml)
[![java-integration-tests](https://github.com/feast-dev/feast/actions/workflows/java_master_only.yml/badge.svg?branch=master&event=push)](https://github.com/feast-dev/feast/actions/workflows/java_master_only.yml)
[![linter](https://github.com/feast-dev/feast/actions/workflows/linter.yml/badge.svg?branch=master&event=push)](https://github.com/feast-dev/feast/actions/workflows/linter.yml)
[![Docs Latest](https://img.shields.io/badge/docs-latest-blue.svg)](https://docs.feast.dev/)
[![Python API](https://img.shields.io/readthedocs/feast/master?label=Python%20API)](http://rtd.feast.dev/)
Expand Down

0 comments on commit 5560caf

Please sign in to comment.