Skip to content

Commit

Permalink
Remove logLevel & logType from job service helm charts
Browse files Browse the repository at this point in the history
Signed-off-by: Tsotne Tabidze <tsotnet@gmail.com>
  • Loading branch information
tsotnet committed Oct 23, 2020
1 parent e6c0887 commit 5ad7a3d
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 12 deletions.
2 changes: 0 additions & 2 deletions infra/charts/feast/charts/feast-jobservice/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ Current chart version is `0.8-SNAPSHOT`
| livenessProbe.periodSeconds | int | `10` | How often to perform the probe |
| livenessProbe.successThreshold | int | `1` | Min consecutive success for the probe to be considered successful |
| livenessProbe.timeoutSeconds | int | `5` | When the probe times out |
| logLevel | string | `"WARN"` | Default log level, use either one of `DEBUG`, `INFO`, `WARN` or `ERROR` |
| logType | string | `"Console"` | Log format, either `JSON` or `Console` |
| nodeSelector | object | `{}` | Node labels for pod assignment |
| podLabels | object | `{}` | Labels to be added to Feast Job Service pods |
| prometheus.enabled | bool | `true` | Flag to enable scraping of Feast Job Service metrics |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,6 @@ spec:
{{- end }}

env:
- name: LOG_TYPE
value: {{ .Values.logType | quote }}
- name: LOG_LEVEL
value: {{ .Values.logLevel | quote }}

{{- if .Values.gcpServiceAccount.enabled }}
- name: GOOGLE_APPLICATION_CREDENTIALS
value: /etc/secrets/google/{{ .Values.gcpServiceAccount.existingSecret.key }}
Expand Down
5 changes: 0 additions & 5 deletions infra/charts/feast/charts/feast-jobservice/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ gcpServiceAccount:
# gcpProjectId -- Project ID to use when using Google Cloud services such as BigQuery, Cloud Storage and Dataflow
gcpProjectId: ""

# logType -- Log format, either `JSON` or `Console`
logType: Console
# logLevel -- Default log level, use either one of `DEBUG`, `INFO`, `WARN` or `ERROR`
logLevel: WARN

prometheus:
# prometheus.enabled -- Flag to enable scraping of metrics
enabled: true
Expand Down

0 comments on commit 5ad7a3d

Please sign in to comment.