Skip to content

Commit

Permalink
README fixes
Browse files Browse the repository at this point in the history
Signed-off-by: Tommy Hughes <tohughes@redhat.com>
  • Loading branch information
tchughesiv committed Oct 9, 2024
1 parent 30832d1 commit 7a781ad
Show file tree
Hide file tree
Showing 5 changed files with 420 additions and 21 deletions.
3 changes: 3 additions & 0 deletions infra/feast-operator/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,6 @@ go.work
*.swp
*.swo
*~

# Installer file generated by Kustomize - skip 'dist/' directories within the Feast project except this one.
!dist/
2 changes: 1 addition & 1 deletion infra/feast-operator/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ vet: ## Run go vet against code.
go vet ./...

.PHONY: test
test: manifests generate fmt vet envtest ## Run tests.
test: build-installer fmt vet lint envtest ## Run tests.
KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" go test $$(go list ./... | grep -v /e2e) -coverprofile cover.out

# Utilize Kind or modify the e2e tests to load the image locally, enabling compatibility with other vendors.
Expand Down
53 changes: 34 additions & 19 deletions infra/feast-operator/README.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
# feast-operator
// TODO(user): Add simple overview of use/purpose

## Description
// TODO(user): An in-depth paragraph about your project and overview of use
# Feast Operator
This is a K8s Operator that can be used to deploy and manage **Feast**, an open source feature store for machine learning.

## Getting Started

Expand All @@ -13,26 +10,16 @@
- Access to a Kubernetes v1.11.3+ cluster.

### To Deploy on the cluster
**Build and push your image to the location specified by `IMG`:**

```sh
make docker-build docker-push IMG=<some-registry>/feast-operator:tag
```

**NOTE:** This image ought to be published in the personal registry you specified.
And it is required to have access to pull the image from the working environment.
Make sure you have the proper permission to the registry if the above commands don’t work.

**Install the CRDs into the cluster:**

```sh
make install
```

**Deploy the Manager to the cluster with the image specified by `IMG`:**
**Deploy the Manager to the cluster:**

```sh
make deploy IMG=<some-registry>/feast-operator:tag
make deploy
```

> **NOTE**: If you encounter RBAC errors, you may need to grant yourself cluster-admin
Expand Down Expand Up @@ -73,7 +60,7 @@ Following are the steps to build the installer and distribute this project to us
1. Build the installer for the image built and published in the registry:

```sh
make build-installer IMG=<some-registry>/feast-operator:tag
make build-installer
```

NOTE: The makefile target mentioned above generates an 'install.yaml'
Expand All @@ -90,7 +77,35 @@ kubectl apply -f https://raw.githubusercontent.com/<org>/feast-operator/<tag or
```

## Contributing
// TODO(user): Add detailed information on how you would like others to contribute to this project
Additional Feast contrib information can be found on the project's [README](https://github.com/feast-dev/feast?tab=readme-ov-file#-contributing).

**Before submitting a PR, the following command should run to a successful completion:**

```sh
make test
```

**Build and push your image to the location specified by `IMG`:**

```sh
make docker-build docker-push IMG=<some-registry>/feast-operator:<some-tag>
```

**NOTE:** This image ought to be published in the personal registry you specified.
And it is required to have access to pull the image from the working environment.
Make sure you have the proper permission to the registry if the above commands don’t work.

**Install the CRDs into the cluster:**

```sh
make install
```

**Deploy the Manager to the cluster with the image specified by `IMG`:**

```sh
make deploy IMG=<some-registry>/feast-operator:<some-tag>
```

### Prerequisites
- go version v1.21
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ metadata:
}
]
capabilities: Basic Install
createdAt: "2024-10-02T20:24:54Z"
createdAt: "2024-10-09T16:00:46Z"
operators.operatorframework.io/builder: operator-sdk-v1.37.0
operators.operatorframework.io/project_layout: go.kubebuilder.io/v4
name: feast-operator.v0.40.0
Expand Down
Loading

0 comments on commit 7a781ad

Please sign in to comment.