tests for pg and mysql

Signed-off-by: Achal Shah <achals@gmail.com>
feast-dev · Jun 2, 2022 · b7e33ee · b7e33ee
1 parent 9add91d
commit b7e33ee
Show file tree

Hide file tree

Showing 3 changed files with 310 additions and 12 deletions.
diff --git a/sdk/python/feast/infra/registry_stores/sql.py b/sdk/python/feast/infra/registry_stores/sql.py
@@ -53,23 +53,23 @@
 entities = Table(
     "entities",
     metadata,
-    Column("entity_id", String, primary_key=True),
+    Column("entity_id", String(50), primary_key=True),
     Column("last_updated_timestamp", BigInteger, nullable=False),
     Column("entity_proto", LargeBinary, nullable=False),
 )
 
 data_sources = Table(
     "data_sources",
     metadata,
-    Column("data_source_name", String, primary_key=True),
+    Column("data_source_name", String(50), primary_key=True),
     Column("last_updated_timestamp", BigInteger, nullable=False),
     Column("data_source_proto", LargeBinary, nullable=False),
 )
 
 feature_views = Table(
     "feature_views",
     metadata,
-    Column("feature_view_name", String, primary_key=True),
+    Column("feature_view_name", String(50), primary_key=True),
     Column("last_updated_timestamp", BigInteger, nullable=False),
     Column("materialized_intervals", LargeBinary, nullable=True),
     Column("feature_view_proto", LargeBinary, nullable=False),
@@ -78,47 +78,47 @@
 request_feature_views = Table(
     "request_feature_views",
     metadata,
-    Column("feature_view_name", String, primary_key=True),
+    Column("feature_view_name", String(50), primary_key=True),
     Column("last_updated_timestamp", BigInteger, nullable=False),
     Column("feature_view_proto", LargeBinary, nullable=False),
 )
 
 on_demand_feature_views = Table(
     "on_demand_feature_views",
     metadata,
-    Column("feature_view_name", String, primary_key=True),
+    Column("feature_view_name", String(50), primary_key=True),
     Column("last_updated_timestamp", BigInteger, nullable=False),
     Column("feature_view_proto", LargeBinary, nullable=False),
 )
 
 feature_user_metadata = Table(
     "feature_metadata",
     metadata,
-    Column("feature_name", String, primary_key=True),
+    Column("feature_name", String(50), primary_key=True),
     Column("last_updated_timestamp", BigInteger, nullable=False),
     Column("feature_metadata_binary", LargeBinary, nullable=False),
 )
 
 feature_services = Table(
     "feature_services",
     metadata,
-    Column("feature_service_name", String, primary_key=True),
+    Column("feature_service_name", String(50), primary_key=True),
     Column("last_updated_timestamp", BigInteger, nullable=False),
     Column("feature_service_proto", LargeBinary, nullable=False),
 )
 
 saved_datasets = Table(
     "saved_datasets",
     metadata,
-    Column("saved_dataset_name", String, primary_key=True),
+    Column("saved_dataset_name", String(50), primary_key=True),
     Column("last_updated_timestamp", BigInteger, nullable=False),
     Column("saved_dataset_proto", LargeBinary, nullable=False),
 )
 
 validation_references = Table(
     "validation_references",
     metadata,
-    Column("validation_reference_name", String, primary_key=True),
+    Column("validation_reference_name", String(50), primary_key=True),
     Column("last_updated_timestamp", BigInteger, nullable=False),
     Column("validation_reference_proto", LargeBinary, nullable=False),
 )