Skip to content

Commit

Permalink
update documentation to reflect current API and add cassandra store t…
Browse files Browse the repository at this point in the history
…o docs
  • Loading branch information
smadarasmi committed Jan 3, 2020
1 parent 71c9713 commit bc8f3bc
Show file tree
Hide file tree
Showing 2 changed files with 76 additions and 37 deletions.
95 changes: 67 additions & 28 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,35 +54,11 @@ mvn --projects core spring-boot:run
# If Feast Core starts successfully, verify the correct Stores are registered
# correctly, for example by using grpc_cli.
grpc_cli call localhost:6565 GetStores ''
grpc_cli call localhost:6565 ListStores ''
# Should return something similar to the following.
# Note that you should change BigQuery projectId and datasetId accordingly
# in "$FEAST_HOME/core/src/main/resources/application.yml"
store {
name: "SERVING"
type: REDIS
subscriptions {
name: "*"
version: ">0"
}
redis_config {
host: "localhost"
port: 6379
}
}
store {
name: "WAREHOUSE"
type: BIGQUERY
subscriptions {
name: "*"
version: ">0"
}
bigquery_config {
project_id: "my-google-project-id"
dataset_id: "my-bigquery-dataset-id"
}
# Should return something similar to the following if you have not updated any stores
{
"store": []
}
```

Expand All @@ -105,6 +81,69 @@ grpc_cli call localhost:6566 GetFeastServingType ''
type: FEAST_SERVING_TYPE_ONLINE
```

#### Updating a store

Create a new Store by sending a request to Feast Core.

```
# Example of updating a redis store
grpc_cli call localhost:6565 UpdateStore '
store {
name: "SERVING"
type: REDIS
subscriptions {
name: "*"
version: ">0"
}
redis_config {
host: "localhost"
port: 6379
}
}
'
# Other supported stores examples (replacing redis_config):
# BigQuery
bigquery_config {
project_id: "my-google-project-id"
dataset_id: "my-bigquery-dataset-id"
}
# Cassandra: two options in cassandra depending on replication strategy
# See details: https://docs.datastax.com/en/cassandra/3.0/cassandra/architecture/archDataDistributeReplication.html
#
# Please note that table name must be "feature_store" as is specified in the @Table annotation of the
# datastax object mapper
# SimpleStrategy
cassandra_config {
bootstrap_hosts: "localhost"
port: 9042
keyspace: "feast"
table_name: "feature_store"
replication_options {
class: "SimpleStrategy"
replication_factor: 1
}
}
# NetworkTopologyStrategy
cassandra_config {
bootstrap_hosts: "localhost"
port: 9042
keyspace: "feast"
table_name: "feature_store"
replication_options {
class: "NetworkTopologyStrategy"
east: 2
west: 2
}
}
# To check that the Stores has been updated correctly.
grpc_cli call localhost:6565 ListStores ''
```

#### Registering a FeatureSet

Expand Down
18 changes: 9 additions & 9 deletions serving/src/main/java/feast/serving/FeastProperties.java
Original file line number Diff line number Diff line change
Expand Up @@ -107,39 +107,39 @@ public int getRedisPoolMaxIdle() {
return this.redisPoolMaxIdle;
}

public int getCassandraPoolCoreLocalConnections {
public int getCassandraPoolCoreLocalConnections() {
return this.cassandraPoolCoreLocalConnections;
}

public int getCassandraPoolMaxLocalConnections {
public int getCassandraPoolMaxLocalConnections() {
return this.cassandraPoolMaxLocalConnections;
}

public int getCassandraPoolCoreRemoteConnections {
public int getCassandraPoolCoreRemoteConnections() {
return this.cassandraPoolCoreRemoteConnections;
}

public int getCassandraPoolMaxRemoteConnections {
public int getCassandraPoolMaxRemoteConnections() {
return this.cassandraPoolMaxRemoteConnections;
}

public int getCassandraPoolMaxRequestsLocalConnection {
public int getCassandraPoolMaxRequestsLocalConnection() {
return this.cassandraPoolMaxRequestsLocalConnection;
}

public int getCassandraPoolMaxRequestsRemoteConnection {
public int getCassandraPoolMaxRequestsRemoteConnection() {
return this.cassandraPoolMaxRequestsRemoteConnection;
}

public int getCassandraPoolNewLocalConnectionThreshold {
public int getCassandraPoolNewLocalConnectionThreshold() {
return this.cassandraPoolNewLocalConnectionThreshold;
}

public int getCassandraPoolNewRemoteConnectionThreshold {
public int getCassandraPoolNewRemoteConnectionThreshold() {
return this.cassandraPoolNewRemoteConnectionThreshold;
}

public int getCassandraPoolTimeoutMillis {
public int getCassandraPoolTimeoutMillis() {
return this.cassandraPoolTimeoutMillis;
}

Expand Down

0 comments on commit bc8f3bc

Please sign in to comment.