Fix empty array when retrieving stats data (#930)

feast-dev · Aug 5, 2020 · be0d54a · be0d54a
1 parent c05865e
commit be0d54a
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/core/src/main/java/feast/core/service/StatsService.java b/core/src/main/java/feast/core/service/StatsService.java
@@ -129,6 +129,9 @@ public GetFeatureStatisticsResponse getFeatureStatistics(GetFeatureStatisticsReq
         List<FeatureNameStatistics> featureNameStatistics =
             getFeatureNameStatisticsByDate(
                 statisticsRetriever, featureSet, features, timestamp, request.getForceRefresh());
+        if (featureNameStatistics.size() != 0) {
+          featureNameStatisticsList.add(featureNameStatistics);
+        }
         featureNameStatisticsList.add(featureNameStatistics);
         timestamp += 86400; // advance by a day
       }
@@ -147,14 +150,16 @@ public GetFeatureStatisticsResponse getFeatureStatistics(GetFeatureStatisticsReq
         List<FeatureNameStatistics> featureNameStatistics =
             getFeatureNameStatisticsByDataset(
                 statisticsRetriever, featureSet, features, datasetId, request.getForceRefresh());
-        featureNameStatisticsList.add(featureNameStatistics);
-        if (featureNameStatisticsList.size() == 0) {
-          throw new RetrievalException(
-              String.format(
-                  "Unable to find any data over provided data sets %s",
-                  request.getIngestionIdsList()));
+        if (featureNameStatistics.size() != 0) {
+          featureNameStatisticsList.add(featureNameStatistics);
         }
       }
+      if (featureNameStatisticsList.size() == 0) {
+        throw new RetrievalException(
+            String.format(
+                "Unable to find any data over provided data sets %s",
+                request.getIngestionIdsList()));
+      }
     }
 
     // Merge statistics values across days/datasets