Fix no ttl logic

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
feast-dev · Jul 26, 2022 · c6536e7 · c6536e7
1 parent 3f243ef
commit c6536e7
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/sdk/python/feast/infra/offline_stores/file.py b/sdk/python/feast/infra/offline_stores/file.py
@@ -635,6 +635,14 @@ def _filter_ttl(
             )
         ]
 
+        df_to_join = df_to_join.persist()
+    else:
+        df_to_join = df_to_join[
+            # do not drop entity rows if one of the sources returns NaNs
+            df_to_join[timestamp_field].isna()
+            | (df_to_join[timestamp_field] <= df_to_join[entity_df_event_timestamp_col])
+        ]
+
         df_to_join = df_to_join.persist()
 
     return df_to_join